Skip to content

Conversation

@ChristophWurst
Copy link
Member

How to test

  1. Create four contacts
  2. Set organization to A for two of them, B for the others
  3. Connect the two people of each organization
  4. Go to the charts page

Main: if you are lucky the charts are sorted by chance. If so, rename organization A to C
This branch: the charts are always sorted.

Bildschirmfoto vom 2022-09-23 19-19-59

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst added bug Something isn't working 3. to review Waiting for reviews design Related to the design labels Sep 23, 2022
@ChristophWurst ChristophWurst added this to the v5.0 milestone Sep 23, 2022
@ChristophWurst ChristophWurst self-assigned this Sep 23, 2022
@ChristophWurst ChristophWurst mentioned this pull request Sep 23, 2022
23 tasks
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 31.21% // Head: 31.21% // No change to project coverage 👍

Coverage data is based on head (115b9c8) compared to base (f388856).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2973   +/-   ##
=========================================
  Coverage     31.21%   31.21%           
  Complexity      253      253           
=========================================
  Files           109      109           
  Lines          1858     1858           
  Branches        218      218           
=========================================
  Hits            580      580           
  Misses         1163     1163           
  Partials        115      115           
Impacted Files Coverage Δ
src/components/OrgChart.vue 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐘

Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, i didnt test it

@GretaD GretaD merged commit 761a016 into main Sep 26, 2022
@GretaD GretaD deleted the fix/sort-org-charts branch September 26, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working design Related to the design

Projects

Development

Successfully merging this pull request may close these issues.

4 participants